fix(e2e): Add p-map override to fix React Router 7 test builds #18068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/react-router-7-framework-node-20-18/package.json
Show resolved
Hide resolved
Lms24
reviewed
Oct 31, 2025
dev-packages/e2e-tests/test-applications/react-router-7-framework-node-20-18/package.json
Show resolved
Hide resolved
logaretm
approved these changes
Oct 31, 2025
Lms24
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ERR_REQUIRE_ESM error in React Router 7 E2E tests by pinning p-map to v4 which supports CommonJS, resolving incompatibility with @react-router/dev v7.5+ that uses require() instead of dynamic import().
React Router should fix this upstream, this is a workaround now.